chore: use espree's built-in types #284
Draft
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for eslint-code-explorer failed. Why did it fail? →
|
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request removes the redundant
@types/espreedependency sinceespreenow ships with its own TypeScript type definitions. It updates the codebase to use espree's built-in types instead of the separate DefinitelyTyped packageWhat changes did you make? (Give an overview)
@types/espreedependency fromdevDependenciesVersiontype with espree's built-inEcmaVersiontype throughout the codebase@ts-expect-errorcomment inuse-ast.tsthat was suppressing a type mismatch error (now resolved)This PR depends on espree v11.1.0 which has not been released yet. Keeping this as a draft until the release is available.